luaver should not be executable (reversing #34) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making ./luaver executable (#34), which was my PR, revealed to cause various problems.
First, that change shows the help text unexpectedly, for instance:
https://travis-ci.org/DhavalKapil/luaver/jobs/264895203#L412
Second, combined commands like
. /path/to/luaver && luaver installdoes not works in expected way.Homebrew/homebrew-core#16839 (comment)
Solving these problems are hard because there are no easy ways to tell if the script was sourced or directly-executed.
In conclusion, I apologize for my carelessness and my fault, 🙇 but #34 should be reversed 😿.
Since
./luavershould not be directly-executed, executable permission flag should also be dropped.